Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

man: Note semantics combining root.transient with composefs.enabled #3351

Merged
merged 1 commit into from
Dec 19, 2024
Merged

man: Note semantics combining root.transient with composefs.enabled #3351

merged 1 commit into from
Dec 19, 2024

Conversation

cgwalters
Copy link
Member

It's all quite confusing having to reason about both the pre-composefs ostree and the composefs version. But hopefully soon we more firmly leave behind that first legacy.

@cgwalters cgwalters enabled auto-merge December 6, 2024 20:27
@ruihe774
Copy link
Contributor

Line 124 also needs to be modified:

with the upper directory being a hidden directory (in the underlying system root filesystem) that will persist across reboots by default.

@cgwalters cgwalters force-pushed the fix-transient-root-doc branch from 9a8a491 to 1c2149e Compare December 17, 2024 21:04
@cgwalters
man: Note semantics combining root.transient with composefs.enabled
786b38c 
It's all quite confusing having to reason about both the pre-composefs
ostree and the composefs version. But hopefully soon we more firmly
leave behind that first legacy.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters force-pushed the fix-transient-root-doc branch from 1c2149e to 786b38c Compare December 17, 2024 21:04
@cgwalters
Copy link
Member Author

cgwalters commented Dec 17, 2024 •
edited
Loading

Line 124 also needs to be modified:

Thanks! Indeed. And now that I look more closely we actually just error out with root.transient when composefs isn't enabled; I think the doc was written about an earlier version and then we backed out of that.

Reworded this entirely.

@cgwalters cgwalters merged commit 45ddf3b into ostreedev:main Dec 19, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeckersb jeckersb jeckersb approved these changes

@allisonkarlitskaya allisonkarlitskaya Awaiting requested review from allisonkarlitskaya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgwalters @ruihe774 @jeckersb